Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid importHref if this element is already registered as a custom el… #4

Merged
merged 2 commits into from
Nov 11, 2016

Conversation

garryyao
Copy link
Contributor

@garryyao garryyao commented Nov 7, 2016

#3

@runn-vermel
Copy link
Contributor

HI @garryyao

Thanks for the Pull Request! Overall, this is great, but there are a couple of things i'm a bit worried about -

  1. Polymer.telemetry is going away with Polymer 2.0 - so, not something we want to rely on if we don't have to. having said that, i don't know of another way to do this, so.. we might have to live with it.
  2. javascript .find doesn't work in IE at all (edge excepted), can you please re-write that so it also works in IE?

Thanks again!

@mdwragg
Copy link
Contributor

mdwragg commented Nov 8, 2016

Nice catches @runn-vermel.

@garryyao
Copy link
Contributor Author

Nice catches, as you mentioned I cannot find a better alternative to Polymer.telemetry without unexpected side-effect or potentially performance issue (e.g. the document.createElement hack) I think we can stay with this and pull-request Polymer/webcomponents.js for that.

So here is just to make the patch work on IE.

Thanks for you time on reviewing.

@runn-vermel runn-vermel merged commit 10681ce into PredixDev:master Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants