Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on ImageMagick convert command #2210

Open
rbeezer opened this issue Jul 17, 2024 · 2 comments
Open

Remove dependency on ImageMagick convert command #2210

rbeezer opened this issue Jul 17, 2024 · 2 comments
Assignees
@Alex-Jordan
Labels
code cleanup maintenance

Comments

@rbeezer
Copy link
Collaborator

rbeezer commented Jul 17, 2024

As of #2186 the convert executable is only needed for the gauntlet of EPUB auto-generated covers.

Can we coax pyMuPDF into doing the job? Or something else we already use? Or skip that attempt entirely?

@oscarlevin might be interested collaterally.
@Alex-Jordan
Copy link
Contributor

The gauntlet was a fun exercise, but I'm fine with simplifying things to either (a) you provide the image yourself or (b) there is one fallback with "the best" chance of working for all users. Is it worth keeping the gauntlet or going with just one fallback? (I guess then it's a hard question as to which thing should be the fallback...)

@rbeezer
Copy link
Collaborator Author

rbeezer commented Jul 17, 2024

One fallback would be great. A balance of functionality and likelihood of success?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alex-Jordan Alex-Jordan

Labels
code cleanup maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rbeezer @Alex-Jordan