Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hyper-V Remoting when using remoting import #24032

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

jborean93
Copy link
Collaborator

PR Summary

When on a Windows version that cannot load the Hyper-V module the State property will be of the string type. This change ensures that PowerShell can still parse this value to the VMState type as expected when the module was loaded natively. This should allow PSRemoting cmdlets that call Get-VM to properly get the VM State property.

PR Context

Fixes: #24014

I don't have a Server 2016 host to test against but it seems like the only other props used from Get-VM are a String and Guid types which should work without any issues in an implicitly remoted module import.

PR Checklist

When on a Windows version that cannot load the Hyper-V module the State
property will be of the string type. This change ensures that PowerShell
can still parse this value to the VMState type as expected when the
module was loaded natively. This should allow PSRemoting cmdlets that
call Get-VM to properly get the VM State property.
@jborean93 jborean93 closed this Jul 9, 2024
@jborean93 jborean93 reopened this Jul 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Jul 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jul 18, 2024
@jborean93 jborean93 closed this Jul 23, 2024
@jborean93 jborean93 reopened this Jul 23, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Jul 30, 2024
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daxian-dbw daxian-dbw merged commit c9bd109 into PowerShell:master Aug 1, 2024
37 checks passed
@daxian-dbw daxian-dbw added CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log and removed Review - Needed The PR is being reviewed labels Aug 1, 2024
@jborean93 jborean93 deleted the Hyper-V-remoting branch August 1, 2024 18:25
@jborean93
Copy link
Collaborator Author

Thanks for the review and fixing up that indentation @daxian-dbw!

chrisdent-de pushed a commit to chrisdent-de/PowerShell that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enter-PSSession with VMName gives cast error
2 participants