devcontainers: mount workspace in /PowerShell #23857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
microsoft-github-policy-service
bot
added
the
Review - Needed
fedora is not supported by PowerShell anymore
Update to a supported version of Ubuntu
TravisEz13
approved these changes
Jul 31, 2024
microsoft-github-policy-service
bot
removed
the
Review - Needed
TravisEz13
added
Review - Needed
chrisdent-de
pushed a commit
to chrisdent-de/PowerShell
that referenced
this pull request
Sep 12, 2024
* devcontainers: mount workspace in /PowerShell * Delete .devcontainer/fedora30 directory fedora is not supported by PowerShell anymore * Update Dockerfile Update to a supported version of Ubuntu --------- Co-authored-by: Travis Plunk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR fixes #23854.
To build packages,
Start-PSPackageexpects the repository to be at/Powershell, but devcontainers mount it by default at/workspaces/name-of-the-folder.This fix configures the devcontainers to mount the workspace at
/Powershell, so thatStart-PSPackageworks as expected.The fix was tested by building a 7.4.2 package on the Ubuntu 18.04 devcontainer (see this branch).
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).