Import middleware signed #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey. Can you please also push the package-lock updates? |
This reverts commit 83456e3.
|
done @VisargD |
|
Hey! Looks like the formatting was not done on the start-test.js file. Can you please check once? Thanks. |
|
Done @VisargD My contributions should run smoothly now, I fixed my environment. |
VisargD
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: sign commits
add a || npm format in case of failing to check before commit
convert require to import
Description: (optional)
fix require into import
Detailed change 2
Motivation: (optional)
the bundling is not working, due to the require statement
Related Issues: (optional)
signed version of #511 , sorry for the oopsie