Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate entry for Malie-City in locations.csv #1097

Open
O-Tahmas opened this issue May 27, 2024 · 2 comments
Open

Duplicate entry for Malie-City in locations.csv #1097

O-Tahmas opened this issue May 27, 2024 · 2 comments

Comments

@O-Tahmas
Copy link
Contributor

Hi!

I've noticed that on locations data - https://pokeapi.co/api/v2/location - all generation name combinations are unique except for id=768 and id=1045

https://pokeapi.co/api/v2/location/768
https://pokeapi.co/api/v2/location/1045

Both are malie-city entries and I'm not sure how they differ. I've opened a PR that proposes to delete out location/1045 , by doing so all (region_id , identifier) are unique in locations.csv , as currently the only dupe pair is the above, which does lead me to believe its a duplicate data entry.

Thanks,
Omar
@edenbynever
Copy link
Contributor

Both are malie-city entries and I'm not sure how they differ.

The handful of region 7 entries at the end of locations.csv are intended to refer to their manifestations in Ultra Sun/Moon, and they do all appear to be distinct from their corresponding Sun/Moon entries, with the differences having to do with the Pokémon available to catch and/or the trainers available for battle.

malie-city is the only one that tripped your uniqueness check because the others have specific areas tacked on in the Sun/Moon case (cf. hauoli-city vs. hauoli-city--marina).

I suppose the fix would be to change the region column to (or add) a version column. It's not clear whether that would be worthwhile for just these few locations, but it may be the case that there are plenty of others to which this distinction would apply.

Renaming id=768 to malie-city--proper seems like a decent middle-of-the-road solution.

@O-Tahmas
Copy link
Contributor Author

Thanks, and makes sense on the possible can-of-worms!

I've taken your suggestion and opened a PR renaming id=768 to malie-city--proper

@O-Tahmas O-Tahmas mentioned this issue Jun 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@O-Tahmas @edenbynever