Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with item flag countable #1047

Open
Genschere opened this issue Feb 24, 2024 · 4 comments
Open

Problem with item flag countable #1047

Genschere opened this issue Feb 24, 2024 · 4 comments

Comments

@Genschere
Copy link

Might be a minor thing but I wondered what the item flag (item_flags.csv) countable actually means. It seems hard to misunderstand but if it really means items that can have a count of how many there are, the data is quite bad on this.
As example: all pokeballs are countable but berries are not. Actually most items that have a count in the games are not flagged as countable.
I wonder if there is a special reason for it or if nobody bothered setting it because almost everything can have a count anyway. The only items that are non-countable are actually key and story items with special purpose like the bike.

Would it not make more sense to change this to a non-countable flag and only mark these "few" items with it?
I know TMs are a bit more complicated on this since it depends on the generation if the item is unique or can have a count but since TMs are a bit special anyway this shouldn't be a reason to not correct this.

@GreatNovaDragon
Copy link
Contributor

IMO, the flag countable, or an counterflag uncountable, isnt needed, cause the non-countables should be base items, any other item is countable, with the exception of TMs between gen5-7 and HMs sofar they existed, but the data displays the most current data.
one could make their counterability based upon categoric exclusion in code.

@Genschere
Copy link
Author

True, but why does it even exist then?
It could simply be removed.

@GreatNovaDragon
Copy link
Contributor

I muse, cause its an carryover from veekun/pokedex now outdated models

@Naramsim
Copy link
Member

Naramsim commented Mar 1, 2024

Yep, most surely is an outdated model/piece of data. The prose says Has a count in the bag, so berries should be countable. And maybe every item, nowadays, but I don't know anything about gens past 3rd.

We could update the data and reflect the current real values, or flip the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants