Fix minor test failure from change to astropy.units namespace
#2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
plasmapy.dispersion
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2842 /- ##
=======================================
Coverage 95.16% 95.16%
=======================================
Files 107 107
Lines 9608 9608
Branches 2225 2225
=======================================
Hits 9143 9143
Misses 277 277
Partials 188 188 ☔ View full report in Codecov by Sentry. |
namurphy
added
no changelog entry needed
run weekly tests in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a change to the namespace in
astropy.unitsso thatastropy.units.core.UnitTypeErrorno longer exists (astropy/astropy#16868).Based on the discussion in that issue, it sounds better to import something directly from
astropy.unitsrather than the specific modules (i.e., useu.UnitTypeErrorvsastropy.units.core.UnitTypeError). Fortunately, this pattern is what we usually do anyway.Note: there's still another error in the development version of
astropy.unitsthat this PR doesn't fix.