Add Nox session to CI to ensure consistency of pyproject.toml with pinned requirements
#2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
CI
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2794 /- ##
==========================================
- Coverage 95.16% 94.36% -0.80%
==========================================
Files 107 107
Lines 9608 9608
Branches 2225 2225
==========================================
- Hits 9143 9067 -76
- Misses 277 347 70
- Partials 188 194 6 ☔ View full report in Codecov by Sentry. |
…ments-consistency
…ments-consistency
namurphy
requested review from
ejohnson-96
and removed request for
a team and
ejohnson-96
…ments-consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
validate_requirementssession for Nox. This session makes sure that it is possible to simultaneously install the pinned requirements inci_requirements/with all of the dependency sets inpyproject.toml.While we would normally be able to tell when this happens with the
docsandtestsNox sessions, we wouldn't get an error message. Adding this check to CI will help tell contributors what to do when they run into this problem (i.e., runnox -s requirements).