Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some variables of array types were converted to Span<T> , ReadOnlySpan<T>, or IReadOnlyList<T> #583

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

Lehonti
Copy link
Contributor

@Lehonti Lehonti commented Oct 23, 2023

In general, the rule is:

  • IReadOnlyList<T> for arrays that are being created by the method called
  • ReadOnlySpan<T> for arrays that are merely being referenced and only being read
  • Span<T> for arrays that are merely being referenced and being written

@Lehonti Lehonti marked this pull request as ready for review October 23, 2023 00:56
@cameronwhite cameronwhite merged commit a4cf890 into PintaProject:master Oct 24, 2023
5 checks passed
@Lehonti Lehonti deleted the improvement/creating_readonly branch October 24, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants