Grouped coordinates in point structs
#576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like these points are describing a rectangle, so maybe just go all the way to using a |
|
Sure, good idea. There is probably an off-by-one error in the original code (see line 321 of |
| updated_x2 = Math.Max (bounds.X bounds.Width, updated_x2); | ||
| updated_y2 = Math.Max (bounds.Y bounds.Height, updated_y2); | ||
| updated_area = RectangleI.FromLTRB ( | ||
| left: Math.Min (bounds.X, updated_area.X), |
There was a problem hiding this comment.
I think this is now just equivalent to RectangleI.Union()?
There was a problem hiding this comment.
Thanks, I didn't know this method already existed. I've updated the code accordingly
| updated_y1 = bounds.Y; | ||
| updated_x2 = bounds.X bounds.Width; | ||
| updated_y2 = bounds.Y bounds.Height; | ||
| updated_area = new ( |
There was a problem hiding this comment.
Can this just be updated_area = bounds ?
There was a problem hiding this comment.
Thanks for noticing this, I've now shortened the code according to your suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
LivePreviewManagerandAsyncEffectRenderer