Added IsTileable property to effects
#556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// If the ROIs are subdivided (in rows, for example) and the effect is applied to each subdivision | ||
| /// separately, is the end result the same as applying it to the original ROIs? | ||
| /// </summary> | ||
| public abstract bool IsTileable { get; } |
There was a problem hiding this comment.
What do you think about defaulting this to true to reduce boilerplate, since this is the case for all existing effects?
There was a problem hiding this comment.
@cameronwhite I made the property abstract on purpose because I figured tileability should be a conscious choice. What do you think?
There was a problem hiding this comment.
I don't have a strong opinion, so I'm fine to keep it as-is since you've already made the changes anyway
Pinta.Core/Effects/BaseEffect.cs
Outdated
| @@ -37,6 37,12 @@ namespace Pinta.Core; | |||
| [Mono.Addins.TypeExtensionPoint] | |||
| public abstract class BaseEffect | |||
| { | |||
| /// <summary> | |||
| /// If the ROIs are subdivided (in rows, for example) and the effect is applied to each subdivision | |||
There was a problem hiding this comment.
I would word this as something like:
Specifies whether Render() can be called separately (and possibly in parallel) for different sub-regions of the image.
If false, Render() will be called once with the entire region the effect is applied to.
This is required for effects which cannot be applied independently to each pixel, e.g. if the effect accumulates information from previously processed pixels.
There was a problem hiding this comment.
@cameronwhite I've now used your wording.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for implementing #457
Nothing is being done with the property yet, but that's one of the next steps