wrong month shown when setting minDate to a later year #93

eduter · 2013-08-21T16:28:48Z

When you set minDate for a date after the currently selected date, the calendar, when shown, should display the month where minDate is. This works if both dates are in the same year, but if the new minDate's year is greater than the selected one, the month shown will be a mix of the selected date's month with the minDate's year.

Example:

selected date: 2013-08-21
minDate: 2014-01-21
month shown: 2014-08

Apparently, modifying 2 if statements from the draw method to be like this solved the problem:

if (this._y < minYear) {
    this._y = minYear;
    this._m = minMonth;
} else if (this._y == minYear && !isNaN(minMonth) && this._m < minMonth) {
   this._m = minMonth;
}
if (this._y > maxYear) {
    this._y = maxYear;
    this._m = maxMonth;
} else if (this._y == maxYear && !isNaN(maxMonth) && this._m > maxMonth) {
    this._m = maxMonth;
}

The text was updated successfully, but these errors were encountered:

leads · 2013-09-30T14:29:20Z

Thanks for this solution @eduter

cupofjoakim · 2013-12-13T09:50:28Z

Nice. I just wish stuff like this was incorporated into the library instead of laying on the side like this.

bjbrewster · 2014-03-28T07:13:53Z

I'm assuming this happens when you initialize Pikaday with a default selected date before the minDate as looking into the setMinDate function (and setMaxDate as well), they do not update the minMonth, minYear, maxMonth, and maxYear options as these are only set on initialisation which is a separate bug in itself. From what I can tell, this does indeed fix the issue mentioned and will add to my PR that fixes many little issues like this.

The wrong month is sometimes shown when minDate year > default date's From the issue's description: When you set minDate for a date after the currently selected date, the calendar, when shown, should display the month where minDate is. This works if both dates are in the same year, but if the new minDate's year is greater than the selected one, the month shown will be a mix of the selected date's month with the minDate's year. There is a separate issue in that `setMinDate` and `setMaxDate` do not update the min/maxMonth and min/maxYear internal options.

* bjbrewster/master: Fix Date.parse bug when using Datejs Fix issue Pikaday#93 wrong month sometimes shown Update README description of defaultDate option Update README Add Ember and Knockout examples Add inputFormats option and parseDate method Add onClear callback and clearInvalidInput option Conflicts: README.md pikaday.js

bjbrewster mentioned this issue Mar 28, 2014

Allow multiple input formats, add onClear callback for better Ember/Knockout/etc integration and allow other date libraries instead of Moment.js #134

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wrong month shown when setting minDate to a later year #93

wrong month shown when setting minDate to a later year #93

eduter commented Aug 21, 2013

leads commented Sep 30, 2013

cupofjoakim commented Dec 13, 2013

bjbrewster commented Mar 28, 2014

wrong month shown when setting minDate to a later year #93

wrong month shown when setting minDate to a later year #93

Comments

eduter commented Aug 21, 2013

leads commented Sep 30, 2013

cupofjoakim commented Dec 13, 2013

bjbrewster commented Mar 28, 2014