Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raising change event when nothing has changed #154

Open
sparc opened this issue Jun 21, 2014 · 2 comments
Open

Raising change event when nothing has changed #154

sparc opened this issue Jun 21, 2014 · 2 comments

Comments

@sparc
Copy link

sparc commented Jun 21, 2014

When the pickaday object is created and attached to an already existing field that has a valid date, the filed is set again with the same date and the change event is fired (line 683), but nothing has really changed.

Changing line 683:

if (this._o.field) {

to

if (!preventOnSelect && this._o.field) {

fixed the problem
@kevinvangelder
Copy link

👍 This, in combination with a mistake I was making, caused me a lot of pain. I'd be fine with it triggering an "initialized" or similar event, but triggering change when initialized is unexpected behavior.

@stevepiron
Copy link

@sparc thank you for the tip. Too bad it's not been implemented 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sparc @stevepiron @kevinvangelder