Decompose TabCompleteEvent into PlayerTabCompleteEvent and TabCompletionResponseEvent #1389
873
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionResponseEvent. The original TabCompleteEvent has been deprecated and is no longer called.
…he same time and both the suggestions of them have been modified, the modified suggestions provided by TabCompletionResponseEvent will be used.
powercasgamer
suggested changes
Jul 25, 2024
Comment on lines
74
to
77
| "player=" player | ||
| ", partialMessage='" partialMessage '\'' | ||
| ", suggestions=" suggestions | ||
| '}'; |
api/src/main/java/com/velocitypowered/api/event/player/PlayerTabCompleteEvent.java
Show resolved
Hide resolved
api/src/main/java/com/velocitypowered/api/event/player/TabCompleteEvent.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/velocitypowered/api/event/player/TabCompletionResponseEvent.java
Show resolved
Hide resolved
Comment on lines
92
to
96
| "player=" player | ||
| ", partialMessage='" partialMessage '\'' | ||
| ", suggestions=" suggestions | ||
| ", result=" result | ||
| '}'; |
There was a problem hiding this comment.
fix indenting here
Comment on lines
69
to
72
| "player=" player | ||
| ", partialMessage='" partialMessage '\'' | ||
| ", result=" result | ||
| '}'; |
There was a problem hiding this comment.
fix indenting
| */ | ||
| public class ClientConfigSessionHandler implements MinecraftSessionHandler { | ||
| public class ClientPlaySessionHandler implements MinecraftSessionHandler { |
There was a problem hiding this comment.
Most of these changes should be undone
…leteEvent.java Co-authored-by: powercas_gamer <[email protected]>
fix identing
fix identing
added javadoc tag & fixed identing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decompose TabCompleteEvent into PlayerTabCompleteEvent and TabCompletionResponseEvent. The original TabCompleteEvent has been deprecated.
Now we can trigger PlayerTabCompleteEvent when the player issues a Tab complete action and modify the "partialMessage" sent by the player to the remote server. When the remote server returns the content of Tab complete, a TabCompletionResponseEvent is triggered and the contents of the returned "suggestions" list can be modified.
If TabCompleteEvent and TabCompletionResponseEvent are listening at the same time and both the suggestions of them have been modified, the modified suggestions provided by TabCompletionResponseEvent will be used.