Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Work In Progress merge request, CAN NOT merge directly now.
Motivation
When I tried to add some test cases for
cli.js
, I found some test cases will run fail for some reason, for example,npm.config.get('registry')
will get a wrong registry(https://registry.yarnpkg.com/
) sometimes, I am sure about that the registry(https://registry.yarnpkg.com/
) does not exist in any related configuration file.In addition, use
npm
lib to write.npmrc
file is unnecessary,fs.writeFileSync
is enough. And the programmatic API was removed innpm
from v8.0.0, as we can see inindex.js
, so, thevar npm = require('npm')
usage is not recommended and already has been deprecated.I will do
npm
dependencyrequest
withnode-fetch