[Fix] Bugfix about requirements / to_uint8 and clean #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddlers/transforms/functions.py
Outdated
| im = _two_percent_linear(im) | ||
| im = np.uint8(im * 255) | ||
| return im | ||
| if dtype[:-2] == "uint" and np.max(dtype) < 256: |
There was a problem hiding this comment.
想问一下这里使用这种办法判断uint8类型主要是出于什么样的原因呀？
There was a problem hiding this comment.
考虑到有些图像明明就是0-255像素的uint图像，但是可能保存为了uint16等，针对这种图像我感觉可以直接使用np.uint8。晖哥看你觉得呢
There was a problem hiding this comment.
考虑到有些图像明明就是0-255像素的uint图像，但是可能保存为了uint16等
这种情况感觉不是很显式，我们这里来主观做这样的判断可能不太合适~ 我建议还是直接判断dtype为uint8的情况，剩余的由用户根据自己数据的性质自行处理
Bobholamovic
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes / Clean
PR changes
Transforms / Tools / Requirements
Description
mask2shape重复且无法使用的mask2geojson工具，在mask2shape已经可以导出shape和geojson。to_uint8，当输入本来就是uint8的图像时，目前该方法会* 255从而造成问题。例如在paddlers.utils.visualize.map_display中显示错误。