Fix output NaNs and event names #93
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezapartas
reviewed
Jun 15, 2023
| if binary.event in ["oCE2", "oDoubleCE2"]: | ||
| binary.event = "oMerging2" | ||
| if double_CE: | ||
| binary.event = 'DCE_merger' |
There was a problem hiding this comment.
maybe make it obvious it is at the onset/start of the process of merging (not just in general a merger product), by making it "DCE_merger_start", consistent with your implementation of "*_start" in this PR
ezapartas
reviewed
Jun 15, 2023
| if double_CE: | ||
| binary.event = 'DCE_merger' | ||
| else: | ||
| binary.event = 'CE_merger' |
There was a problem hiding this comment.
Same here, CE_merger_start (or CE_merging_start)
|
Update (March 28): @astroJeff , it looks like stalling, hence please get back to work on it or consider to close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated branch from @celiotine and me. We have adjusted events to clarify that they are _start and _end and adjusted the flowchart to correspond.