-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Sara Profile (Drude convolution) #288
Comments
jdtsmith
changed the title
Implement Sara Profile
Implement Sara Profile (Drude convolution)
May 13, 2024
Relevant comment from PR#289, regarding redshift:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@sarduval has explored
Gaussian x Drude
convolutions (the functional form of which we nickname "the Sara profile". She's come up with a mapping scheme to update a given Drude to another broader Drude, which works for most reasonable ranges of resolution and PAH features. Right now our "parent" model for Drudes bakes in the instrument line spread function convolution: not good.The idea is that science packs should be "pure" and devoid of any artifacts of the instrument. So just as we express lines as Gaussians of a computed FWHM, we'd compute updated FWHM for Drude's too. Other features (BB, modifiedBB) are too broad for this to matter much.
@drvdputt, any thoughts on where this should go? I guess the
Fitter
is in charge of marrying instrument pack, figuring out gaussians, etc.? So it should do this too. Do we updatefwhm
for lines in theFeatures
table after a fit? We need a way of taking a fitted FWHM and running the transform backwards: so we can recover the true intrinsic feature width.The text was updated successfully, but these errors were encountered: