-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible API change: Separate fit results from Model/add history to Features Table #256
Comments
Yeah,
|
jdtsmith
changed the title
Possible API change: Separate fit results from Model
Possible API change: Separate fit results from Model/add history to Features Table
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In our current design, the model details, fit settings and fit results are put together in the Model class. This brings some complexity with it:
Alternative design
Possible issues with this:
We're not going to change this now, since we really need to get PAHFIT running. But I really wanted to write this down, and we should keep this type of redesign in mind if we run into more symptoms of the same underlying conceptual problem.
The text was updated successfully, but these errors were encountered: