-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use eCommerce theme (OCC-161) #300
Comments
@Piedone can I have access to this repo in case I need to push a PR, or shall I fork, then commits from the forked repo? |
@DAud-IcI is the project leader here, so Dávid please advise, |
I don't mind. @hishamco, I've added you to the developers group, please check if you have the access. |
Hope to contribute to the repo in the upcoming future, thanks David |
IMHO, if you don't have the time to invest in a dedicated Commerce theme, TheTheme would be a better default choice than TheBlogTheme. |
What's the advantage of using TheTheme vs TheBlogTheme? |
The default recipe that you provide is meant to show the features than the module offers. Using TheBlogTheme can be kind of a misguiding distraction for the user. But then, I guess we all agree that the most fitted UI would be a simple commerce theme as Hisham suggested:
|
For anyone taking this: |
@sarahelsaig can I add this theme to https://github.com/OrchardCoreContrib/OrchardCoreContrib.Themes then we could override the views (something similar to the blog theme) or shall we add it into the repo |
You can add a base theme into OrchardCoreContrib.Themes if that helps your workflow, but the theme and the OCC-specific views should be in this repo. Or did you mean something else? |
Sure, or we could override them, let me have a deep look to the current customization in |
Note for when this is done: check if |
I will busy nowadays with revising and finalizing OC PRs then I can have time for other related OC stuff |
it would be nice to use eCommerce theme instead of building on top of the Blog theme. We could use something like https://startbootstrap.com/templates/ecommerce I can submit a PR if the team agrees with the idea
Jira issue
The text was updated successfully, but these errors were encountered: