Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ITranslationProvider.LoadTranslationsAsync() #15886

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add ITranslationProvider.LoadTranslationsAsync() #15886

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift click to select a range
11d28ed
Add ITranslationProvider.LoadTranslationsAsync()
hishamco Apr 26, 2024
62a0e0b
IPluralStringLocalizer.GetTranslationAsync()
hishamco Apr 26, 2024
f8246fd
Fix the build
hishamco Apr 26, 2024
0041fbf
Apply suggestions from code review
hishamco Apr 26, 2024
ee4a668
Address feedback
hishamco Apr 26, 2024
93a802e
Use IAsyncEnumerable
hishamco Apr 26, 2024
3035a04
Revert "Use IAsyncEnumerable"
hishamco Apr 26, 2024
239bc7f
Merge branch 'main' into hishamco/translation-provider
hishamco May 2, 2024
5cd5a85
Merge branch 'main' into hishamco/translation-provider
hishamco May 3, 2024
8fdfc09
Fix merge conflict
hishamco May 3, 2024
47050eb
GetAllStringsFromCultureHierarchyAsync() return IAsyncEnumerable<Loca…
hishamco May 3, 2024
49920ba
Merge branch 'main' into hishamco/translation-provider
hishamco Jun 16, 2024
ef0a4b2
Merge branch 'main' into hishamco/translation-provider
hishamco Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the build
  • Loading branch information
@hishamco
hishamco committed Apr 26, 2024
commit f8246fd2e1806fd2572a36b04bf36ec702d06b3b
2 changes: 1 addition & 1 deletion src/OrchardCore/OrchardCore.Localization.Core/PortableObject/PortableObjectHtmlLocalizer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 41,7 @@ public override LocalizedHtmlString this[string name]
if (_localizer is IPluralStringLocalizer pluralLocalizer && arguments.Length == 1 && arguments[0] is PluralizationArgument)
{
// Get an unformatted string and all non plural arguments (1st one is the plural count).
var (translation, argumentsWithCount) = pluralLocalizer.GetTranslation(name, arguments);
var (translation, argumentsWithCount) = pluralLocalizer.GetTranslationAsync(name, arguments).GetAwaiter().GetResult();
hishamco marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

@sebastienros sebastienros Sep 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this PR to come back to this pitfall, for every single invokation of the localizer. It was better before, even if it was not reading the file asynchronously once)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe because we didn't do it the right way from the beginning :)


// Formatting will use non plural arguments if any.
return ToHtmlString(translation, argumentsWithCount);
Expand Down