Fix: reverse train direction command did not validate the given vehicle properly #9947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le properly You could give a wagon in the chain to reverse (which makes no functional sense ofc). In result, only parts of the vehicle were reversing, leading to weird crashes.
michicc
approved these changes
Jul 9, 2022
Joel-Milligan
pushed a commit
to Joel-Milligan/OpenTTD
that referenced
this pull request
Nov 10, 2022
…le properly (OpenTTD#9947) You could give a wagon in the chain to reverse (which makes no functional sense ofc). In result, only parts of the vehicle were reversing, leading to weird crashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Was fuzzing the commands. Crashes happened.
Description
I think I understood this part of the code correctly, but surely could use a second pair of eyes on this logic.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.