Add the ability to call uac_auth() without incrementing CSEQ #1613
Conversation
The default value is 1; meaning no change to the normal behavior of the uac_auth() exported function in the OpenSIPS uac module.
If the exported parameter, increment_seq, is the default value (1) then perform the addition to CSEQ as normal. If the value was set to zero (0), then leave the CSEQ as received.
|
Hi @mstocco ! |
While doing strict routing (e.g. the R-URI host is a local domain) and executing the module callbacks, the rr module would provide some bogus memory pointer as the result of the rr_api.get_route_param() function. Although opensips would not crash due to the dangling pointer residing in pkg memory, some callbacks would misbehave (e.g. uac_auth() would fail to adjust the outbound ACK CSeq, since it cannot locate the ";aci" Route header field parameter within the dangling pkg area). Related to #1613
While doing strict routing (e.g. the R-URI host is a local domain) and executing the module callbacks, the rr module would provide some bogus memory pointer as the result of the rr_api.get_route_param() function. Although opensips would not crash due to the dangling pointer residing in pkg memory, some callbacks would misbehave (e.g. uac_auth() would fail to adjust the outbound ACK CSeq, since it cannot locate the ";aci" Route header field parameter within the dangling pkg area). Related to #1613 (cherry picked from commit ec89b78)
This will allow uac_auth to accept a string param (or not).
Hi @bogdan-iancu, Anything but “CSEQ_SKIP” (or no param at all) is intended to have uac_auth() continue as it always has. Thoughts? |
This solves a problem where a UA is known to accept SIP Authorization without requiring the CSEQ being incremented and allowing for relaying without CSEQ adjustments.