Enable building input/output facets from the visitors #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:client/java
pawel-big-lebowski
force-pushed
the
spark/dataset-factory-refactor
branch
from
4c24424 to
6f49f6a
Compare
pawel-big-lebowski
force-pushed
the
spark/dataset-factory-refactor
branch
from
6f49f6a to
13f2d9a
Compare
boring-cyborg
bot
added
the
area:documentation
pawel-big-lebowski
force-pushed
the
spark/dataset-factory-refactor
branch
from
13f2d9a to
83a3f59
Compare
Signed-off-by: Pawel Leszczynski <[email protected]>
Signed-off-by: Pawel Leszczynski <[email protected]>
pawel-big-lebowski
force-pushed
the
spark/dataset-factory-refactor
branch
from
83a3f59 to
e80067b
Compare
mobuchowski
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, visitors and dataset builders create dataset objects through the DatasetFactory. This concept does not allow providing input nor output facets.
This PR enables it by including
DatasetCompositeFacetsBuilderto include already existing facets as well asinput/outputones. Extending existing methods to allow it requires changes in several places of the codebase.