Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: allow custom headers in HTTP transport #3116

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

JDarDagran
Copy link
Contributor

Problem

Needs #3114 so it works with env var configuration.

Closes: #2907

Solution

Add custom_headers in HttpConfig.

Note: Env var configuration would work only if whole transport is set with dynamic env vars introduced in #3114. This means you can't e.g. set OPENLINEAGE_URL and OPENLINEAGE__TRANSPORT__CUSTOM_HEADERS. Instead of OPENLINEAGE_URL set OPENLINEAGE__TRANSPORT__TYPE=http and OPENLINEAGE__TRANSPORT__URL=....

Checklist

  • You've signed-off your work
  • Your pull request title follows our guidelines
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • Your comment includes a one-liner for the changelog about the specific purpose of the change (not required for changes to tests, docs, or CI config)
  • You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
  • You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2024 contributors to the OpenLineage project

@JDarDagran JDarDagran requested a review from a team as a code owner September 24, 2024 22:57
@boring-cyborg boring-cyborg bot added area:client/python openlineage-python area:documentation Improvements or additions to documentation area:tests Testing code language:python Uses Python programming language labels Sep 24, 2024
@JDarDagran JDarDagran force-pushed the python/allow-custom-headers branch from 9cbf6cb to d4db05d Compare September 24, 2024 22:58
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.70%. Comparing base (3e6a3b4) to head (28bf806).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3116    /-   ##
=======================================
  Coverage   85.70%   85.70%           
=======================================
  Files          54       54           
  Lines        3112     3112           
=======================================
  Hits         2667     2667           
  Misses        445      445           
Flag Coverage Δ
85.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JDarDagran JDarDagran force-pushed the python/allow-custom-headers branch from d4db05d to 28bf806 Compare September 25, 2024 20:19
@JDarDagran JDarDagran merged commit 05ec44f into main Sep 26, 2024
33 checks passed
@JDarDagran JDarDagran deleted the python/allow-custom-headers branch September 26, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:client/python openlineage-python area:documentation Improvements or additions to documentation area:tests Testing code language:python Uses Python programming language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Support custom headers for Python http client
3 participants