[SPARK][JAR-VERIFIER] verify major java version of compiled classes #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawel-big-lebowski
force-pushed
the
jar-verifier/verify-class-compiler
branch
from
2e74dc6 to
4e0712d
Compare
boring-cyborg
bot
added
the
area:documentation
pawel-big-lebowski
force-pushed
the
jar-verifier/verify-class-compiler
branch
from
4e0712d to
56f0de6
Compare
Signed-off-by: Pawel Leszczynski <[email protected]>
pawel-big-lebowski
force-pushed
the
jar-verifier/verify-class-compiler
branch
from
56f0de6 to
811c803
Compare
mobuchowski
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support Spark 4.0, we want to be able to run gradle tests with Java 17 and be able to compile
openlineage-sparkwith Java 17 and target compatibility set to Java 8. It's reasonable to make sure and verify if all the classes compiled have bytecode version corresponding to Java 8.This PR extends JarVerifier plugin to check
majorJavaVersionof each class from within a packed jar. It makes sure if all the versions are below a configured value. If no configured value found, then52is the default (which represents Java 8).