spark: add GCP run and job facets #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pahulpreet Singh <[email protected]>
Signed-off-by: Pahulpreet Singh <[email protected]>
codelixir
force-pushed
the
feature/gcp-facets
branch
from
dde2159 to
a98ff94
Compare
Signed-off-by: Pahulpreet Singh <[email protected]>
integration/spark/shared/src/main/java/io/openlineage/spark/agent/facets/EnvironmentFacet.java
Outdated
Show resolved
Hide resolved
integration/spark/shared/src/main/java/io/openlineage/spark/agent/util/GCPUtils.java
Outdated
Show resolved
Hide resolved
integration/spark/shared/src/main/java/io/openlineage/spark/agent/util/GCPUtils.java
Outdated
Show resolved
Hide resolved
integration/spark/shared/src/main/java/io/openlineage/spark/agent/util/GCPUtils.java
Outdated
Show resolved
Hide resolved
integration/spark/shared/src/main/java/io/openlineage/spark/agent/util/GCPUtils.java
Show resolved
Hide resolved
Signed-off-by: Pahulpreet Singh <[email protected]>
Signed-off-by: Pahulpreet Singh <[email protected]>
Signed-off-by: Pahulpreet Singh <[email protected]>
codelixir
changed the title
Signed-off-by: Pahulpreet Singh <[email protected]>
codelixir
force-pushed
the
feature/gcp-facets
branch
from
c7d93bc to
77d78b1
Compare
Signed-off-by: Pahulpreet Singh <[email protected]>
codelixir
force-pushed
the
feature/gcp-facets
branch
from
77d78b1 to
20b197a
Compare
Signed-off-by: Pahulpreet Singh <[email protected]>
Signed-off-by: Pahulpreet Singh <[email protected]>
Signed-off-by: Pahulpreet Singh <[email protected]>
Signed-off-by: Pahulpreet Singh <[email protected]>
|
The CI tests which are failing were taken care of in #2655 |
pawel-big-lebowski
approved these changes
Jun 18, 2024
could you then rebase your changes? |
Signed-off-by: Pahulpreet Singh <[email protected]>
|
Great job! Congrats on your first merged pull request in OpenLineage! |
codelixir
added a commit
to codelixir/OpenLineage
that referenced
this pull request
Jun 20, 2024
Signed-off-by: Pahulpreet Singh <[email protected]>
mobuchowski
pushed a commit
that referenced
this pull request
Jun 20, 2024
* Limit logging from MockServer interactions in GCPUtilsTest Signed-off-by: Pahulpreet Singh <[email protected]> * update changelog for #2643 Signed-off-by: Pahulpreet Singh <[email protected]> --------- Signed-off-by: Pahulpreet Singh <[email protected]>
fafnirZ
pushed a commit
to fafnirZ/OpenLineage
that referenced
this pull request
Jul 3, 2024
* spark: add GCP environment facet Signed-off-by: Pahulpreet Singh <[email protected]> * apply spotless check Signed-off-by: Pahulpreet Singh <[email protected]> * spotless check Signed-off-by: Pahulpreet Singh <[email protected]> * address comments Signed-off-by: Pahulpreet Singh <[email protected]> * Revise GCP Dataproc Run Facet Signed-off-by: Pahulpreet Singh <[email protected]> * add GCP common Job Facet Signed-off-by: Pahulpreet Singh <[email protected]> * update GCP Dataproc facet as per OpenLineage#2771 Signed-off-by: Pahulpreet Singh <[email protected]> * Update schema URL for GCP facets as per the new registry Signed-off-by: Pahulpreet Singh <[email protected]> * fix PMD violations Signed-off-by: Pahulpreet Singh <[email protected]> * Writing tests for GCPUtils Signed-off-by: Pahulpreet Singh <[email protected]> * add license header Signed-off-by: Pahulpreet Singh <[email protected]> * fix pmd violations Signed-off-by: Pahulpreet Singh <[email protected]> * Resolve merge conflicts and bugs Signed-off-by: Pahulpreet Singh <[email protected]> --------- Signed-off-by: Pahulpreet Singh <[email protected]>
fafnirZ
pushed a commit
to fafnirZ/OpenLineage
that referenced
this pull request
Jul 3, 2024
* Limit logging from MockServer interactions in GCPUtilsTest Signed-off-by: Pahulpreet Singh <[email protected]> * update changelog for OpenLineage#2643 Signed-off-by: Pahulpreet Singh <[email protected]> --------- Signed-off-by: Pahulpreet Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Adds GCPRunFacetBuilder and GCPJobFacetBuilder to collect GCP-specific properties at run and job levels respectively.
Closes: #2641
Solution
The
SPARK_DIST_CLASSPATHproperty can be used to determine whether it is a GCP Dataproc environment, depending on which we can decide to add the respective facet builders to the list. Other properties are obtained from Google's compute metadata API.One-line summary:
Adds GCPRunFacetBuilder and GCPJobFacetBuilder to report additional facets when running on Google Cloud Platform
Checklist
SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project