Support for ParticipantBuiltInTopicData listener #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failed in ./run-test.pl. But this error was not there when tested in local. |
|
Which version of node are you using to test locally? We probably need to configure Travis CI to use the Node 6.x LTS version. |
|
I used Node 8.x |
|
Please try changing .travis.yml on your branch to have https://docs.travis-ci.com/user/languages/javascript-with-nodejs/ If you run multiple times on your local build, do any of them fail the same way that the Travis build did? |
|
I forgot to unsubscribe to the ParticipantBuilTopicDataReader. That's why the process didn't exit properly and got a timeout error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataListener implementation is done for ParticipantBuiltInTopic.
BuiltInTopic data parser is implemented, which generates UserDataQos and BuiltInTopicKey.
JS callback function is invoked on new participant.