Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync master to 5.0.x #5968

Merged
merged 356 commits into from
Apr 22, 2020
Merged

Sync master to 5.0.x #5968

merged 356 commits into from
Apr 22, 2020

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Apr 17, 2020

Merge conflicts (partial):

        both modified:   modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/ElmClientCodegen.java
        both modified:   modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/RustServerCodegen.java
        deleted by us:   modules/openapi-generator/src/main/resources/csharp-netcore/Project.mustache
        deleted by us:   modules/openapi-generator/src/main/resources/csharp-netcore/project.json.mustache
        deleted by us:   modules/openapi-generator/src/main/resources/elm/api.mustache
        deleted by us:   modules/openapi-generator/src/main/resources/elm/api018.mustache
        both modified:   modules/openapi-generator/src/main/resources/elm/customTypeDecoder.mustache
        both modified:   modules/openapi-generator/src/main/resources/elm/customTypeEncoder.mustache
        both modified:   modules/openapi-generator/src/main/resources/elm/model.mustache
        deleted by us:   modules/openapi-generator/src/main/resources/elm/modelTypeArray.mustache
        deleted by us:   modules/openapi-generator/src/main/resources/elm/modelTypePrimitive.mustache
        both modified:   modules/openapi-generator/src/main/resources/elm/recordFieldValueDecoder.mustache
        both modified:   modules/openapi-generator/src/main/resources/elm/recordFieldValueEncoder.mustache
        both modified:   modules/openapi-generator/src/main/resources/rust-server/client-mod.mustache
        both modified:   modules/openapi-generator/src/main/resources/rust-server/models.mustache
        both modified:   modules/openapi-generator/src/main/resources/rust-server/server-mod.mustache

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

etherealjoy and others added 30 commits February 25, 2020 17:21
…coding. (#5255)

This way letting WebClient do its Job in encoding the URL.
* [kotlin][client] Add Jackson as serialization library

* [kotlin][client] Add kotlin-client-jackson.sh to kotlin-client-all.sh

* update kotlin client samples

* update doc

Co-authored-by: William Cheng <[email protected]>
* Add error output to the log so that we can make sure why the error occurred

* Fix forbidden method invocation using default charsets
* better code format for java webclient

* prefix local varaible with localVar
…#5395 (#5440)

* Support for additionalProperties in the C generator.

* Support for additionalProperties in the C generator.
* Fix #5420 add headers from configuration object

* Add baseOptions undefined checking #5420

* Update the samples and replace array to object #5420

* Update sample
* [typescript] Clean up modelPropertyNaming across generators
Fixes #2976

Generators without runtime models conversion use "original" property naming by default. It's still possible to change it via cli options

Generators with runtime conversion keep using "camelCase"

* Refactoring: use enum instead of string for modelPropertyNaming

* Restore the original camelCase for var names, decouple it from property names

* Swap toParamName and toVarName logic (looks like I've mistaken them)

* Regenerate docs

* Remove a no longer used private method
* Added support for msvc builds

Moved GCC-specific compile flags to non msvc builds, and added equivalent flags for msvc.

* CMakeLists condition cleanup
When I originally implemented the feature set code, I added the
getter/setter on DefaultCodegen and CodegenConfig as well as on
GeneratorMetadata. GeneratorMetadata also includes the library variation
features. When I went to add library-specific features, I realized the
discrepancy.

This removes the public setter from DefaultCodegen/CodegenConfig, and
adds a protected modifyFeatureSet which accepts a lambda and hides the
builder logic away in the method.

This will be a breaking change for anyone who's created a custom
generator in 4.2.3, so the impact is very limited.
* [swift] make some small improvements

* [swift][client] revert model to use allVars

* PostProcessModelProperty with allVars

* PostProcessModelProperty with vars

* [swift] improve objc interoperability

* [swift] fix swift4 for CI to pass

* [swift] improve objc interoperability

* [swift] improve objc interoperability

* Swift - try to fix build

* [swift] remove pods from git
* scala-sttp-client template

* invoker for sttp fixed and tests added

* clean up pet api test from redunant comments

* docs updated

* fix artefact name, model comments and redunant generic

* code optimization

* cross scala versions 2.11 2.12 2.13

* date serializers extracted and joda enabled as default

* basic and bearer authorization added, apikey in query supported
…) (#5474)

* fix obsolute configuration in generated .rubocop.yml

* fix style of `expect` with block in generated ruby client's test code

* update sample of ruby client
* stripped parameter enabled for all scala based generators

* scala samples updated

* docs generators updated

* fix scalatra. regenerated by openapi3 script.
manually removed enum default value from scalatra example due bug in schema extraction
* various improvements to scala sttp

* update ScalaSttpClientCodegen.java

* add windows batch file

* test scala sttp in jdk8

* fix tempalte directory
* Use the dataType if the baseType is not set

* add tests for passing enum as parameter

* updated requirements file in samples

* Update spec to explicitly name objects and prevent `inline_object`

* use the correct scripts to generate samples (`bin/openapi3/python-flask*`)
* Adds oneOf   anyOf schemas, models and tests to python-experimental

* Adds setUpClass and tearDownClass

* Removes newline in method_init_shared.mustache

* Regenerated v3 spec sample for python-experimental

* Fxes test for discard_unknown_keys

* Moves new models into existing spec, regen python-exp and go-exp

* Also fix python-exp windows file
* [go-experimental] Support aliasing of API keys

* Use {{.}} inside condition

* Use name instead of keyParamName for lookup

* x-lookup to x-auth-id-alias
* [java] Support aliasing of API keys

* Rebuild Java Jersey2 sample client

* x-lookup to x-auth-id-alias

* Regenerated
@wing328
Copy link
Member Author

wing328 commented Apr 17, 2020

@richardwhiuk when you've time, I wonder if you can help resolve the following merge conflicts when syncing master to 5.0.x branch:

        both modified:   modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/RustServerCodegen.java
        both modified:   modules/openapi-generator/src/main/resources/rust-server/client-mod.mustache
        both modified:   modules/openapi-generator/src/main/resources/rust-server/models.mustache
        both modified:   modules/openapi-generator/src/main/resources/rust-server/server-mod.mustache

(search for <<< to identify the merge conflicts)

@wing328 wing328 added this to the 5.0.0 milestone Apr 17, 2020
@eriktim
Copy link
Contributor

eriktim commented Apr 19, 2020

@wing328 for Elm please pick all versions of the 5.0.x branch. I can also push a commit if you prefer that.

@wing328
Copy link
Member Author

wing328 commented Apr 20, 2020

@eriktim please go ahead to update this branch 5.0-sync-master directly.

@eriktim
Copy link
Contributor

eriktim commented Apr 20, 2020

@wing328 I've pushed the required changes. However, due to the Rust conflicts I could not test it properly. It should be fine, but please let me know if you run into issues later.

@wing328
Copy link
Member Author

wing328 commented Apr 20, 2020

Thanks @eriktim 👍

@richardwhiuk
Copy link
Contributor

@wing328 Yep, I'll pick up sorting out the merge conflicts - there is a fair few to get through.

@richardwhiuk
Copy link
Contributor

@wing328 I've fixed up the Rust failures and regenerated the rust server samples. Looks like all the other samples need updating as well - I'll leave that to you.

@wing328
Copy link
Member Author

wing328 commented Apr 20, 2020

@richardwhiuk thanks. Let me take care of that.

@wing328 wing328 removed the WIP Work in Progress label Apr 21, 2020
@wing328 wing328 changed the title [WIP] Sync master to 5.0.x Sync master to 5.0.x Apr 21, 2020
@wing328 wing328 closed this Apr 21, 2020
@wing328 wing328 reopened this Apr 21, 2020
@wing328
Copy link
Member Author

wing328 commented Apr 22, 2020

Closed via #6006 as there seems to be in issue triggering build in CircleCI.

@wing328 wing328 merged commit 90dd7a0 into 5.0.x Apr 22, 2020
@wing328 wing328 deleted the 5.0-sync-master branch April 22, 2020 03:47
wing328 added a commit that referenced this pull request Apr 22, 2020
@wing328
Copy link
Member Author

wing328 commented Apr 22, 2020

Sorry. pressed the wrong button. Reverted the change (90dd7a0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.