Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proofreading fix on MASTG-TEST-0052.md -> Testing Local Data Storage ( by @appknox ) #2551

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Proofreading fix on MASTG-TEST-0052.md -> Testing Local Data Storage ( by @appknox ) #2551

merged 2 commits into from
Feb 20, 2024

Conversation

sk3l10x1ng
Copy link
Collaborator

Thank you for submitting a Pull Request to the OWASP MASTG. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)
  • You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #< insert number here >.

@sk3l10x1ng
Copy link
Collaborator Author

The code block under ""Reading the Keychain"" is not closed properly.
As a result, the entire section of  "Testing Memory for Sensitive Data" topic is included inside a code block on page no. 409 of MASTG pdf release v1.7.0"

cpholguera
cpholguera requested changes Feb 14, 2024
View reviewed changes
tests/ios/MASVS-STORAGE/MASTG-TEST-0052.md Outdated
@@ -100,3 100,4 @@ Note: You may be asked to authenticate using the devices passcode or TouchID
Save the output by adding `--json keychain.json` to this command
Dumping the iOS keychain...
Created Accessible ACL Type Account Service Data
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go back to v1.5.0 and include the missing text from Document/0x06d-Testing-Data-Storage.md

Adapt the headings accordingly.

Suggested change
```
To use Objection to read the Keychain, execute the following command:
...
3. Cache can be also disabled by setting the Cache Policy to [.notAllowed](https://developer.apple.com/documentation/foundation/urlcache/storagepolicy/notallowed "URLCachePolicy notAllowed"). It will disable storing Cache in any fashion, either in memory or on disk.

@cpholguera cpholguera merged commit 1bc4b39 into OWASP:master Feb 20, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushi2k sushi2k sushi2k approved these changes

@cpholguera cpholguera cpholguera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sk3l10x1ng @sushi2k @cpholguera