Technical Writer: made changes to enhance clarity - section in 0x04 ("guide") moved to 0x03 #2548

thornshadow99 · 2024-02-08T20:30:56Z

Thank you for submitting a Pull Request to the OWASP MASTG. Please make sure that:

Your contribution is written in the 2nd person (e.g. you)
Your contribution is written in an active present form for as much as possible.
You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
Your contribution has proper formatted markdown and/or code
Any references to website have been formatted as [TEXT](URL “NAME”)
You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #< insert number here >.

… sections

…larity

cpholguera · 2024-02-09T12:01:40Z

Hi @thornshadow99, you may ignore the spell checker for now, however you have a couple of markdown lint errors which you'd need to fix. Here you can see the file, line number, character position and the error:

Document/0x03-Overview.md:5:54 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
Document/0x04a-Mobile-App-Taxonomy.md:7:43 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
Document/0x04a-Mobile-App-Taxonomy.md:58 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
Document/0x04a-Mobile-App-Taxonomy.md:59 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 3]

cpholguera · 2024-02-09T12:03:18Z

Document/0x03-Overview.md


-The protection of sensitive data, such as user credentials and private information, is crucial to mobile security. If an app uses operating system APIs such as local storage or inter-process communication (IPC) improperly, the app might expose sensitive data to other apps running on the same device. It may also unintentionally leak data to cloud storage, backups, or the keyboard cache. Additionally, mobile devices can be lost or stolen more easily compared to other types of devices, so it's more likely an individual can gain physical access to the device, making it easier to retrieve the data.
+### <A id="datastorage"></a> MASVS-STORAGE: Data Storage and Privacy


Why these <a> elements? Markdown generates HTML IDs automatically

I see now. You want to include an index. You can use the sections titles. Just put them in all lowercase and use dashes. For example:

MASVS-STORAGE: Data Storage and Privacy

Turns into: masvs-storage-data-storage-and-privacy

I got it now. Beg pardon.

thornshadow99 · 2024-02-09T13:11:24Z

So I go into my branch, fix the markdown errors, and resubmit? Rob

…

On Fri, Feb 9, 2024 at 7:01 AM Carlos Holguera ***@***.***> wrote: Hi @thornshadow99 <https://github.com/thornshadow99>, you may ignore the spell checker for now, however you have a couple of markdown lint errors which you'd need to fix. Here you can see the file, line number, character position and the error: Document/0x03-Overview.md:5:54 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1] Document/0x04a-Mobile-App-Taxonomy.md:7:43 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1] Document/0x04a-Mobile-App-Taxonomy.md:58 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2] Document/0x04a-Mobile-App-Taxonomy.md:59 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 3] — Reply to this email directly, view it on GitHub <#2548 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDMXOUPZQNR4KLASTKKVUHLYSYF3DAVCNFSM6AAAAABDAMLIGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZVHAYDKOJXHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

cpholguera · 2024-02-10T08:46:05Z

Hi @thornshadow99, that's correct, you go to your branch and fix those issues and then push. There's no need to open a new Pull Requests. Your push updates the current PR.

cpholguera · 2024-02-10T08:49:29Z

These are the last 2 errors to fix:

Error: Document/0x03-Overview.md:5:54 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

Error: Document/0x04a-Mobile-App-Taxonomy.md:55:367 MD047/single-trailing-newline Files should end with a single newline character

cpholguera · 2024-02-10T08:50:40Z

Document/0x03-Overview.md


-The [OWASP Mobile Application Security _Verification Standard_ (MASVS)](https://mas.owasp.org/MASVS/) defines a mobile app security model and lists generic security requirements for mobile apps. It can be used by architects, developers, testers, security professionals, and consumers to define and understand the qualities of a secure mobile app. The [OWASP Mobile Application Security _Testing Guide_ (MASTG)](https://mas.owasp.org/MASTG/) maps to the same basic set of security requirements offered by the MASVS and depending on the context they can be used individually or combined to achieve different objectives.
+## How to Use the Mobile Application Security Project 


Fix for:

Error: Document/0x03-Overview.md:5:54 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

Suggested change

## How to Use the Mobile Application Security Project

## How to Use the Mobile Application Security Project

Document/0x04a-Mobile-App-Taxonomy.md

cpholguera · 2024-02-10T08:54:00Z

Document/0x03-Overview.md


-The protection of sensitive data, such as user credentials and private information, is crucial to mobile security. If an app uses operating system APIs such as local storage or inter-process communication (IPC) improperly, the app might expose sensitive data to other apps running on the same device. It may also unintentionally leak data to cloud storage, backups, or the keyboard cache. Additionally, mobile devices can be lost or stolen more easily compared to other types of devices, so it's more likely an individual can gain physical access to the device, making it easier to retrieve the data.
+### <A id="datastorage"></a> MASVS-STORAGE: Data Storage and Privacy


Suggested change

### <A id="datastorage"></a> MASVS-STORAGE: Data Storage and Privacy

### MASVS-STORAGE: Data Storage and Privacy

cpholguera · 2024-02-10T08:54:26Z

Document/0x03-Overview.md


-### Data Storage and Privacy (MASVS-STORAGE)
+[Data Storage and Privacy](#datastorage)


Suggested change

[Data Storage and Privacy](#datastorage)

[Data Storage and Privacy](#masvs-storage-data-storage-and-privacy)

I understand now. Just used the wrong reference online. Beg pardon.

thornshadow99 · 2024-02-10T18:57:50Z

Thank you for your help! It is greatly appreciated. :)

…

On Sat, Feb 10, 2024 at 3:54 AM Carlos Holguera ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Document/0x03-Overview.md <#2548 (comment)>: > -### Data Storage and Privacy (MASVS-STORAGE) [Data Storage and Privacy](#datastorage) and so on — Reply to this email directly, view it on GitHub <#2548 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDMXOULX4POUB7FQCL2UAZLYS4YVJAVCNFSM6AAAAABDAMLIGCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZTGYYDENZTGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

0x04: Index properly implemented and alt text given to IMG SRC in line 9

Document/0x04a-Mobile-App-Taxonomy.md

Document/0x03-Overview.md

cpholguera

Thanks a lot @thornshadow99!

thornshadow99 added 2 commits February 7, 2024 13:37

Tech Writer: Made edits for clarity and added extra anchors for MASVS…

f8e977f

… sections

Tech Writer: small edits to Overview and multiple edits to 0x04 for c…

a8158fe

…larity

cpholguera reviewed Feb 9, 2024

View reviewed changes

Eliminated most markdown errors but could not find the last one.

e76cdbb

cpholguera requested changes Feb 10, 2024

View reviewed changes

cpholguera reviewed Feb 10, 2024

View reviewed changes

cpholguera mentioned this pull request Feb 10, 2024

Fixed index and eliminated markdown errors except line 7 #2549

Closed

6 tasks

thornshadow99 added 2 commits February 10, 2024 18:27

0x03: Index properly implemented and file ends with EOF

b0aa72b

0x04: Index properly implemented and alt text given to IMG SRC in line 9

fixed additional error

6b8c8e9

cpholguera requested changes Feb 20, 2024

View reviewed changes

Document/0x04a-Mobile-App-Taxonomy.md Outdated Show resolved Hide resolved

Document/0x03-Overview.md Outdated Show resolved Hide resolved

Apply suggestions from code review

0600858

cpholguera approved these changes Feb 20, 2024

View reviewed changes

cpholguera merged commit 68cc51a into OWASP:master Feb 20, 2024
4 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Technical Writer: made changes to enhance clarity - section in 0x04 ("guide") moved to 0x03 #2548

Technical Writer: made changes to enhance clarity - section in 0x04 ("guide") moved to 0x03 #2548

thornshadow99 commented Feb 8, 2024 •

edited

Loading

cpholguera commented Feb 9, 2024

cpholguera Feb 9, 2024

cpholguera Feb 9, 2024

thornshadow99 Feb 10, 2024

thornshadow99 commented Feb 9, 2024 via email

cpholguera commented Feb 10, 2024

cpholguera commented Feb 10, 2024

cpholguera Feb 10, 2024

thornshadow99 Feb 10, 2024

cpholguera Feb 10, 2024

thornshadow99 Feb 10, 2024

cpholguera Feb 10, 2024

cpholguera Feb 10, 2024

thornshadow99 Feb 10, 2024

thornshadow99 commented Feb 10, 2024 via email

cpholguera left a comment


		The protection of sensitive data, such as user credentials and private information, is crucial to mobile security. If an app uses operating system APIs such as local storage or inter-process communication (IPC) improperly, the app might expose sensitive data to other apps running on the same device. It may also unintentionally leak data to cloud storage, backups, or the keyboard cache. Additionally, mobile devices can be lost or stolen more easily compared to other types of devices, so it's more likely an individual can gain physical access to the device, making it easier to retrieve the data.
		### <A id="datastorage"></a> MASVS-STORAGE: Data Storage and Privacy


		The [OWASP Mobile Application Security _Verification Standard_ (MASVS)](https://mas.owasp.org/MASVS/) defines a mobile app security model and lists generic security requirements for mobile apps. It can be used by architects, developers, testers, security professionals, and consumers to define and understand the qualities of a secure mobile app. The [OWASP Mobile Application Security _Testing Guide_ (MASTG)](https://mas.owasp.org/MASTG/) maps to the same basic set of security requirements offered by the MASVS and depending on the context they can be used individually or combined to achieve different objectives.
		## How to Use the Mobile Application Security Project

	### <A id="datastorage"></a> MASVS-STORAGE: Data Storage and Privacy
	### MASVS-STORAGE: Data Storage and Privacy


		### Data Storage and Privacy (MASVS-STORAGE)
		[Data Storage and Privacy](#datastorage)

	[Data Storage and Privacy](#datastorage)
	[Data Storage and Privacy](#masvs-storage-data-storage-and-privacy)

Technical Writer: made changes to enhance clarity - section in 0x04 ("guide") moved to 0x03 #2548

Technical Writer: made changes to enhance clarity - section in 0x04 ("guide") moved to 0x03 #2548

Conversation

thornshadow99 commented Feb 8, 2024 • edited Loading

cpholguera commented Feb 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MASVS-STORAGE: Data Storage and Privacy

Choose a reason for hiding this comment

thornshadow99 commented Feb 9, 2024 via email

cpholguera commented Feb 10, 2024

cpholguera commented Feb 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thornshadow99 commented Feb 10, 2024 via email

cpholguera left a comment

Choose a reason for hiding this comment

thornshadow99 commented Feb 8, 2024 •

edited

Loading