Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error loading completion #426

Closed
dmd opened this issue Apr 3, 2023 · 2 comments
Closed

error loading completion #426

dmd opened this issue Apr 3, 2023 · 2 comments
Labels
t: Bug

Comments

@dmd
Copy link

dmd commented Apr 3, 2023

Describe the bug

When I load the completion file:

bash: /opt/homebrew/etc/bash_completion.d/pueue: line 15: syntax error near unexpected token `client,add'
bash: /opt/homebrew/etc/bash_completion.d/pueue: line 15: `            Pueue client,add)'

Steps to reproduce

I get this when I start my terminal.

Debug logs (if relevant)

No response

Operating system

MacOS 13

Pueue version

v3.1.2

Additional context

No response
@dmd dmd added the t: Bug label Apr 3, 2023
@mjpieters
Copy link
Contributor

mjpieters commented Apr 3, 2023 •
edited
Loading

This is a clap bug, see clap-rs/clap#4822.

The work-around for now is to manually edit the generated file; for homebrew it's in $(brew --prefix)/etc/bash_completion.d/pueue. Replace all occurences of Pueue client with pueue.

The same issue applies to the zsh completions, but that's far less visible because the completion function is then just ignored. Completions start working after replacing Pueue client with pueue everywhere in $(brew --prefix)/share/zsh/site-functions/_pueue and restarting the shell, however.

Nukesor added a commit that referenced this issue Apr 29, 2023
@Nukesor
fix: autocompletion
68df791 
See #426
@Nukesor
Copy link
Owner

Nukesor commented Apr 29, 2023

I temporarily renamed the names until this is fixed upstream.

@Nukesor Nukesor closed this as completed May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmd @mjpieters @Nukesor