-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward slash character in path incorrectly rejected on Windows #3036
Comments
If you'd like to make a PR, then |
I am a git bash user myself and like the use of / to avoid quoting madness too. Also Windows normally just treats |
Thanks for your report, this is fixed on the factory branch, which is a development version under rapid development. You can try it out by going here: https://nuitka.net/doc/factory.html Feedback on whether this is working is very welcome. Please do not share plans to do it; only confirm or deny that it is working. |
Confirmed working on factory branch 2.5rc3! |
This is part of the latest hotfix. |
Summary
Nuitka is now checking for illegal characters in specified paths, such as (in my case) using the
--include-data-dirs
option. However, this checking is overly restrictive, and prevents Python's cross-platform/
conversion.I believe the simple fix would be to remove the
/
character from the list of illegal characters defined here. I am happy to make this change and submit a PR, but I didn't want to jump to that as I'm not currently near a Windows computer for testing and wasn't sure if there were other implications.Minimal reproducable sample
The following works on Linux, but would fail on Windows (my apologies for the bash syntax in file creation):
You can see the output from my GitHub action with the actual files here. The relevant error message is:
Relevant template questions and answers
Nuitka version, full Python version, flavor, OS, etc. as output by this exact command.
I am running the Nuitka Action on GitHub's hosted windows-2019. I am unable to run this exact command, but the following information was printed as part of the run:
How did you install Nuitka and Python?
Using GitHub actions, specifically:
Note if this is a regression
Yes, this is a regression. The workflow successfully ran in June here
The text was updated successfully, but these errors were encountered: