This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Failure to update .NET AspNet WebApi projects #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Repro for #239 |
This allows the dotnet remove/add commands to work without trying to import a non-existent project
|
The current approach works, but my use case is a bit more complex still - turns out the failure I have is on an imported project in an imported project. Will need to add import traversal :-| |
| @@ -45,7 45,7 @@ public class NuGetUpdatePackageCommand : IUpdatePackageCommand | |||
| } | |||
|
|
|||
| var sources = GetSourcesCommandLine(_sources); | |||
| var arguments = $"update packages.config -Id {currentPackage.Id} -Version {newVersion} {sources}"; | |||
| var arguments = $"update {currentPackage.Path.RelativePath} -Id {currentPackage.Id} -Version {newVersion} {sources}"; | |||
There was a problem hiding this comment.
Check use of DirectoryName and RelativePath here.
I -think_ that the first one is everything but the file name, and the second one is the path from the checkout folder including the file name. You might just want the bare file name in the second one?
There was a problem hiding this comment.
Actually, this change isn't needed - I've left it by accident from a different attempt at solving this.
AnthonySteele
approved these changes
Apr 30, 2018
This might help the random build errors, according to dotnet/sdk#2076
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run NuKeeper on a .NET "classic" WebApi project that has been updated to use PackageReference, attempting to update packages will fail.
That's because a) we can't run NuGet on that (refuses to run without packages.config) and b) can't run dotnet add/remove as those will fail to import the webapi targets file. The workaround is to find Imports that have the problematic (unset) VSToolsPath variable reference and change them to conditional imports. They will work the same in VS build (as the import target is found then) but will be skipped by the dotnet core update commands, allowing NuKeeper to handle the project.