Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiqc : init at 1.15 #249329

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Multiqc : init at 1.15 #249329

wants to merge 3 commits into from

Conversation

apraga
Copy link
Contributor

@apraga apraga commented Aug 15, 2023

Description of changes

New package for generating repoints in bioinformatics.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@zeuner zeuner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that, LGTM.

pkgs/applications/science/biology/multiqc/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/biology/multiqc/default.nix Outdated Show resolved Hide resolved
Dependency for multiqc.
Dependency for multiqc
Spectra and pyaml-env have been added as
dependencies in previous commits.
@apraga
Copy link
Contributor Author

apraga commented Mar 25, 2024

@zeuner Sorry for the delay. Test have been added and a main program too :)

@apraga
Copy link
Contributor Author

apraga commented Apr 8, 2024

@zeuner If you have some time to check this PR, that would be great, thanks !

@apraga
Copy link
Contributor Author

apraga commented Jun 29, 2024

@zeuner Sorry to ping you again, but if you could validate the change, I would appreciate it :)

@edmundmiller edmundmiller mentioned this pull request Aug 4, 2024
13 tasks
@apraga
Copy link
Contributor Author

apraga commented Aug 31, 2024

@zeuner A new PR is a duplicate, not sure what to do there #284361.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants