Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

czkawka: init at 3.0.0 #116441

Merged
merged 1 commit into from
Mar 16, 2021
Merged

czkawka: init at 3.0.0 #116441

merged 1 commit into from
Mar 16, 2021

Conversation

yanganto
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Mar 15, 2021
View reviewed changes
pkgs/tools/misc/czkawka/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/czkawka/default.nix Outdated Show resolved Hide resolved
@yanganto
Copy link
Member Author

@SuperSandro2000 Thanks for the review.

@SuperSandro2000 SuperSandro2000 merged commit 5fa9e28 into NixOS:master Mar 16, 2021
@yanganto yanganto deleted the czkawka-3 branch May 29, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanganto @SuperSandro2000