Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update row dq summary #73

Merged
merged 15 commits into from
Mar 4, 2024
Merged

update row dq summary #73

merged 15 commits into from
Mar 4, 2024

Conversation

jskrajareddy21
Copy link
Contributor

@jskrajareddy21 jskrajareddy21 commented Mar 2, 2024

Description

This PR solves this issue: #53 & #72

Related Issue

Motivation and Context

See issue

How Has This Been Tested?

Screenshots (if appropriate):

Screenshot 2024-03-01 at 5 44 51 PM

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (89da08b) to head (6c241e7).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #73    /-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1453      1465    12     
=========================================
  Hits          1453      1465    12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the PR

@asingamaneni asingamaneni merged commit d0a0dc0 into Nike-Inc:main Mar 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants