Fixes #453 ink strokes not captured until stylus up #540
Conversation
| /// </summary> | ||
| /// <param name="visual">The visual to convert to a DrawingGroup</param> | ||
| /// <param name="drawingGroup">The target DrawingGroup to be populated</param> | ||
| static public void visualToFrozenDrawingGroup(this Visual visual, DrawingGroup drawingGroup) |
There was a problem hiding this comment.
Hi, just a minor tweak in here, but I can do later:
public static void VisualToFrozenDrawingGroup
There was a problem hiding this comment.
Should be updated now. Sorry, we have an awful coding standard at 🏭 to which I am strongly habituated. I think I fixed the flicker as well.
|
Thanks for taking your time to deal with that issue. I'm waiting to get in hands with a computer with touch this week in order to test it. |
|
I still could not test it, is it working ok for you? |
|
Sorry I'm lame - I got pulled into overtime at work. There is still the
edge case that results in it going all wonky. I'll try to fix it this
weekend.
…On Thu, Dec 5, 2019 at 8:32 PM Nicke Manarin ***@***.***> wrote:
I still could not test it, is it working ok for you?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#540?email_source=notifications&email_token=AADV6U4EH63KNR2766WF6HDQXGTTZA5CNFSM4JCQFJLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGCXBAY#issuecomment-562393219>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADV6U5IHFN5NQ3ZZJJKS2TQXGTTZANCNFSM4JCQFJLA>
.
|
|
Sorry for the delay again. I was able to test the recorder by using an input injector (mouse input to touch or pen input). The recorder looks fine. If it's still janky, maybe the |
This fixes #453 by using reflection to get a frozen copy of DrawingGroups from the inking thread's real-time visual. Under normal use cases, it seems strokes are transitioned from the inking thread to the UI thread's InkCanvas when completed (e.g. stylus up). However, in our sort of unique case of animating the drawing process, we do want to see the real-time visual incrementally, so this fix pulls over the partial stroke as DrawingGroups into an image overlay that is Z-ordered above the InkCanvas. This extra partial-stroke-copy logic is only performed when a capture is desired (via thetimer), and the inking overlay is emptied when no partial stroke is alive.