detail::path_base() now supports both path seperators on Windows. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2021
benbarsdell
reviewed
May 17, 2021
Robadob
force-pushed
the
include_linux_on_windows
branch
from
7a5547a
to
3b4ffce
Compare
|
Wasn't aware of those overloads, have checked it still works. Much smaller of a change now. |
benbarsdell
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have tested that it fixes the problem reported in #87.
std::string;:nposis the unsigned value of-1, so can't just usestd::maxwithout some nasty casting.Closes #87