fix: pick random port instead of failing #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fedeztk <[email protected]>
|
I'm having a bit of trouble figuring out how to test it. func TestBusyPort(t *testing.T) {
port := 8080
go http.ListenAndServe(fmt.Sprintf(":%d", port), nil)
assert := assert.New(t)
b := new(bytes.Buffer)
rootCmd.SetOut(b)
rootCmd.SetErr(b)
rootCmd.SetArgs([]string{"validate", "--file", "../examples/check-port.yaml", "testcontainers/helloworld"})
err := rootCmd.Execute()
assert.Nil(err, "should not error")
assert.Contains(b.String(), "Validating testcontainers/helloworld against check-port", "did not validate")
assert.Contains(b.String(), "validation passed", "did not pass")
assert.NotEqual(port, ???) // how do I get the port from here? I need the validatorConfig
}If I test it inside the Can you please advise on how to solve this? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #30.
It is important to notice that such fix does not ensure that all the tests will run successfully as expected, it simply won't fail to start by changing the ports of the container and the checks.
As an example, if we pick the scenario in the aforementioned issue, the test will still fail since nginx does not know which is the right port it should listen to.