-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
The |
I didn't get it to work the way I wanted (in the order that it will be overwritten). Did you manage to keep the functionality as mentioned? I think the plugin might still be interesting, as we can also extend it to read directly from repositories. |
It seems that this plugin would still be interesting with the possibility to extend it to read directly from repositories. I have two comments regarding the expected behaviour of this PR:
|
- Be more verbose in additional_configs.py
@BPdeRooij I believe I have addressed both concerns. |
|
Alright, but won’t the cwd be the folder where you’ve executed the command? Can you edit this in the PR?On Oct 30, 2023, at 10:01 AM, Bart ***@***.***> wrote:
dotenv.load_dotenv expects an explicit file name. It does not start searching from working_dir. For this we could use dotenv.find_dotenv(usecwd=True) and give this as dotenv_path
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This commit implements a method to use the
additional_config
folder to override specific configurations.