Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fixes remap labels from raising an error to just not using them #28

Merged
merged 1 commit into from
Nov 24, 2023
Merged

fixes remap labels from raising an error to just not using them #28

merged 1 commit into from
Nov 24, 2023

Conversation

moerlemans
Copy link
Contributor

Fixes 26

@moerlemans moerlemans linked an issue Nov 24, 2023 that may be closed by this pull request
None remap labels throws an error in callbacks even though they are optional #26
Closed
EricMarcus-ai
EricMarcus-ai approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@EricMarcus-ai EricMarcus-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the rename_labels optional. LGTM

@moerlemans moerlemans merged commit 7e30695 into main Nov 24, 2023
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EricMarcus-ai EricMarcus-ai EricMarcus-ai approved these changes

@JorenB JorenB Awaiting requested review from JorenB

@jonasteuwen jonasteuwen Awaiting requested review from jonasteuwen

@BPdeRooij BPdeRooij Awaiting requested review from BPdeRooij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None remap labels throws an error in callbacks even though they are optional
2 participants
@moerlemans @EricMarcus-ai