-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Consensus] add BlockVerifier
#16147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
mwtian
force-pushed
the
consensus-verifier
branch
from
February 8, 2024 08:45
be19843
to
c2960b3
Compare
arun-koshy
reviewed
Feb 8, 2024
mwtian
commented
Feb 9, 2024
mwtian
force-pushed
the
consensus-verifier
branch
from
February 10, 2024 00:01
212b277
to
6d33b01
Compare
mwtian
force-pushed
the
consensus-verifier
branch
from
February 10, 2024 00:05
6d33b01
to
069b3b7
Compare
mwtian
force-pushed
the
consensus-verifier
branch
from
February 10, 2024 00:09
069b3b7
to
df8ead1
Compare
akichidis
reviewed
Feb 12, 2024
mwtian
changed the title
[Consensus] add BlockVerifier and TransactionVerifier
[Consensus] add Feb 12, 2024
BlockVerifier
mwtian
force-pushed
the
consensus-verifier
branch
from
February 12, 2024 19:52
2767cf3
to
1ee423e
Compare
arun-koshy
approved these changes
Feb 13, 2024
akichidis
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
mwtian
force-pushed
the
consensus-verifier
branch
from
February 13, 2024 17:08
1ee423e
to
90e7597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BlockVerifier
trait andSignedBlockVerifier
impl for verifying block metadata, transactions and ancestors.TransactionVerifier
trait, to be implemented bySuiTxValidator
.ProtocolKeyPair
instead ofNetworkKeyPair
or generic type for block signing.ProtocolKeyPair
is currently BLS and can switch to EdDSA later.BlockDigest
.Test Plan
Unit tests.
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes