Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudIconButton : Add the parameter FullWidth (#9811) #9857

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

vernou
Copy link
Contributor

@vernou vernou commented Sep 23, 2024

Description

This PR add the parameter FullWidth in MudIconButton and MudToggleIconButton.
FullWidth add the class mud-width-full on the button to stretch it.

Visual example :

<p>MudToggleIconButton without FullWidth</p>
<div style="background-color: rgba(51, 170, 51, .05)">
    <MudToggleIconButton Icon="@Icons.Material.Filled.AlarmOff" Color="@Color.Error"
                         ToggledIcon="@Icons.Material.Filled.AlarmOn" ToggledColor="@Color.Success" />
</div>

<br />

<p>MudToggleIconButton with FullWidth</p>
<div style="background-color: rgba(51, 170, 51, .05)">
    <MudToggleIconButton Icon="@Icons.Material.Filled.AlarmOff" Color="@Color.Error"
                         ToggledIcon="@Icons.Material.Filled.AlarmOn" ToggledColor="@Color.Success"
                         FullWidth />
</div>

image

From the issue #9811.

I will do a second PR to manage the case with MudButtonGroup.

How Has This Been Tested?

I added new tests.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added enhancement New feature or request PR: needs review labels Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.82%. Comparing base (28bc599) to head (f12dade).
Report is 492 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9857       /-   ##
==========================================
  Coverage   89.82%   90.82%    0.99%     
==========================================
  Files         412      406       -6     
  Lines       11878    12826      948     
  Branches     2364     2485      121     
==========================================
  Hits        10670    11649      979     
  Misses        681      625      -56     
- Partials      527      552       25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vernou vernou marked this pull request as draft September 24, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant