Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.21%. Comparing base (7576772) to head (fe05561).
Report is 55 commits behind head on dev.

@@            Coverage Diff             @@
##              dev   #10217       /-   ##
==========================================
  Coverage   91.16%   91.21%    0.05%     
==========================================
  Files         411      411              
  Lines       12467    12506       39     
  Branches     2420     2439       19     
==========================================
  Hits        11365    11407       42     
  Misses        557      555       -2     
  Partials      545      544       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I really dont understand what you are trying to achieve here? Could you please elaborate, the issue you refer to and the changes you do, i dont see the connection.

The actual height of MudAppBar not always equals to --mud-appbar-height.
MudAppBar sometimes has actual height of calc(var(--mud-appbar-height) - var(--mud-appbar-height) / 8) with MudBlazor's built-in responsive layout.

This problem making it very difficult to make MudBlazor app with safe area support.
Unless this issue does not exist, we can simply support safe area by

<MudAppBar Style="padding-top: env(safe-area-inset-top)"/>

<MudMainContent Style="margin-top: calc(env(safe-area-inset-top)   var(--mud-appbar-height))">
@Body
</MudMainContent>

This PR makes --mud-appbar-height always matches actual app bar height.

Also we will not merge the current solution to the library because of the CSS added to the :root

Why?
I have never seen such restriction in Contributing.

I really dont understand what you are trying to achieve here? Could you please elaborate, the issue you refer to and the changes you do, i dont see the connection.

The actual height of MudAppBar not always equals to --mud-appbar-height.
MudAppBar sometimes has actual height of calc(var(--mud-appbar-height) - var(--mud-appbar-height) / 8) with MudBlazor's built-in responsive layout.

This problem making it very difficult to make MudBlazor app with safe area support.
Unless this issue does not exist, we can simply support safe area by

<MudAppBar Style="padding-top: env(safe-area-inset-top)"/>

<MudMainContent Style="margin-top: calc(env(safe-area-inset-top)   var(--mud-appbar-height))">
@Body
</MudMainContent>

This PR makes --mud-appbar-height always matches actual app bar height.

Also we will not merge the current solution to the library because of the CSS added to the :root

Why? I have never seen such restriction in Contributing.

Okay then i understand what you are trying to achieve, you want the variable to be updated with the real value depending on device size.

Doing it this way in the root is messy and is always calculated in your browser, see this:
whatitlookslike.webm

The current AppBar Height property is just meant to be the base size, where it gets changed depending on device size. I don't think the gains here is worth moving it all to the root: as a component library as it effects everyone and is a specific request.