Buttons: Use fixed size for layout #10040
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielchalmers
changed the title
|
Default heights: Button 36.5px, Icon Button 48px. Put both in a group (default example):
They don't line up due to the button no longer stretching to fix the size of the icon button. Current:
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10040 /- ##
==========================================
Coverage 91.05% 91.51% 0.46%
==========================================
Files 410 413 3
Lines 12522 12980 458
Branches 2446 2447 1
==========================================
Hits 11402 11879 477
Misses 570 557 -13
Partials 550 544 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #8884. Resolves #4160. Resolves #5306.
Switches from using padding, which allows the inner content to change the size, to a precise, fixed number of pixels that conforms to Material Design 2.
This can be a breaking visual change depending on how the buttons are used; for example, if they were previously allowed to stretch, they will no longer do so.
How Has This Been Tested?
visually
Type of Changes
Checklist
dev).