Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class multiple dispatch #271

Merged
merged 7 commits into from
Aug 13, 2024
Merged

Class multiple dispatch #271

merged 7 commits into from
Aug 13, 2024

Conversation

softmattertheory
Copy link
Contributor

Improves multiple dispatch on classes. Methods are not inherited correctly, and overwrite older methods with equivalent signatures.

Multiple initializer methods can now be provided in class definitions, and they are selected correctly by the virtual machine.

@joshichaitanya3
Copy link
Collaborator

Nice! Is there any particular behavior that needs to be stress tested / could benefit from new tests?

One thing I noticed while running the test suite locally on a Ubuntu machine that some of the tests under matrix that are supposed to throw an error (eg, concatenate_sparse) were taking quite a bit of time (a few seconds) to actually throw the error. The tests are still passing, but wonder if you see this behavior on Mac or any other machines too. I checked that this doesn"t happen on the current dev branch.

@softmattertheory softmattertheory merged commit 2906851 into dev Aug 13, 2024
4 checks passed
@softmattertheory softmattertheory deleted the classmultipledispatch branch August 13, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants