Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SS13 form conversion #19

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

SS13 form conversion #19

wants to merge 24 commits into from

Conversation

Ruinedbun
Copy link

I converted a few forms from the ss13 paradise station wiki

@Moomoobeef
Copy link
Owner

Moomoobeef commented Sep 22, 2024 •
edited
Loading

in addition to all the file-specific comments. Most of these files lack a label. You know that # Document Title thingy at the top of every file in the repo? That is so that printers will label the paper when printing. So add those where they are missing.

After you do that, and you make all the other changes requested, I can probably merge this. Though I might move some files afterward as I did a reorganization between you making the PR and now

@Ruinedbun
Copy link
Author

Added labels to all of them, but I'm not sure what you mean by file-specific comments.

@Moomoobeef
Copy link
Owner

Added labels to all of them, but I'm not sure what you mean by file-specific comments.

I just meant all the reviews left on files themselves

Ruinedbun

This comment was marked as duplicate.

Sign in to view

Ruinedbun
Ruinedbun commented Sep 22, 2024
View reviewed changes
Copy link
Author

@Ruinedbun Ruinedbun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all files

Moomoobeef
Moomoobeef requested changes Oct 10, 2024
View reviewed changes
Copy link
Owner

@Moomoobeef Moomoobeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my god. The review comments I made were pending this whole time and you couldn't see them. I feel like such an idiot I'm so sorry!

Also I noticed you added document titles, but they need to have a space between the '#' and the text:
# label is good
#label is not

Again, sorry about the fuckup on my part!! I feel like an ass

Det Forms/Witness Deposition.txt Show resolved Hide resolved
Fun/Psychologist's Assessment.txt Show resolved Hide resolved
HoP Paperwork/Additional Access Form.txt Outdated Show resolved Hide resolved
Det Forms/Witness Deposition.txt Outdated Show resolved Hide resolved
HoP Paperwork/Additional Access Form.txt Outdated Show resolved Hide resolved
Legal-Forms/Termination of Contract.txt Outdated Show resolved Hide resolved
Legal-Forms/Termination of Contract.txt Show resolved Hide resolved
Practical-Forms/Health Inspector Forms/General Department.txt Outdated Show resolved Hide resolved
Practical-Forms/Mechsuit requisition form.txt Show resolved Hide resolved
Screenshot 2024-09-15 040416.png Outdated Show resolved Hide resolved
Ruinedbun
Ruinedbun commented Oct 11, 2024
View reviewed changes
Copy link
Author

@Ruinedbun Ruinedbun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright all comments with issues should be addressed and fixed.

@Ruinedbun Ruinedbun requested a review from Moomoobeef October 11, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moomoobeef Moomoobeef Awaiting requested review from Moomoobeef

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ruinedbun @Moomoobeef