-
-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: refresh web design, fix several html, css and content issues #2831
Conversation
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. - [Release notes](https://github.com/isaacs/minimatch/releases) - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](caolan/async@v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Claudia Meadows <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment. Not sure the change is justified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Closing. Please recreate this PR against https://github.com/MithrilJS/docs. I preserved history when I created that repo, so you may be able to just Do be aware that your version selector should be redone, as the docs repo is not meaningfully versioned and I ripped out the code supporting most of that. |
@tbreuss Forgot to ping you ⬆️ |
Thanks @dead-claudia. I'm not sure if I can reproduce this properly. The changes were quite extensive. But I will at least try after my vacation in mid-October. |
Since there have been discussions about website re-design for a long time, but it did not really move forward, I have been working on this website cleanup branch. Mainly, because some things are a bit embarrassing.
A preview release can be visited here: https://www.mithriljs.tebe.ch/
I see this as a foundation for the next bigger web design update.
Motivation and Context
How Has This Been Tested?
The edits have been manually tested on my local machine and the preview release (see above).
Types of changes
Bug fix (non-breaking change which fixes an issue)New feature (non-breaking change which adds functionality)Breaking change (fix or feature that would cause existing functionality to change)Checklist:
I have added tests to cover my changes.docs/changelog.md
Changes Details
ES6 on legacy browsers
from Resources to Misc section (to make it less prominent)Learning Resources
from Getting Started to Misc section (to make it less prominent)v1 Documentation
andv0.2 Documentation
from Misc section (we have those links already in the version selector besides the logo, and we don't want to promote older versions, of course)